[webkit-reviews] review denied: [Bug 32610] Web Inspector: Links to source in CPU profiles should open Scripts (debugger) panel : [Attachment 44973] Proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 16 09:11:32 PST 2009


Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 32610: Web Inspector: Links to source in CPU profiles should open Scripts
(debugger) panel
https://bugs.webkit.org/show_bug.cgi?id=32610

Attachment 44973: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=44973&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
>  WebInspector.canShowResourceForURL = function(url, preferredPanel)
>  WebInspector.showResourceForURL = function(url, line, preferredPanel)

It would be much more clear if you made Panel's canShowResource and
showResource accept URL instead of resource. That way you would be able to make
canShowResourceForURL and showResourceForURL here panel-agnostic.


More information about the webkit-reviews mailing list