[webkit-reviews] review granted: [Bug 5578] WebKit does not support DOM Level 3 setIsId and isId : [Attachment 44934] fix broken build and some minor changes

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 5578: WebKit does not support DOM Level 3 setIsId and isId
https://bugs.webkit.org/show_bug.cgi?id=5578

Attachment 44934: fix broken build and some minor changes
https://bugs.webkit.org/attachment.cgi?id=44934&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems OK. r=me

The tests could go further than just checking that something is non-null. For
example, in id-in-param.html you could check that the element returned is the
single param element, which you could locate with getElementsByTagName, for
example. And also the id-in-frameset tests seems to be a little cryptic. Just
doing an alert with the content "1" seems a little weak.