[webkit-reviews] review denied: [Bug 32075] Add workaround for json parsed as unicode : [Attachment 44172] master.cfg patch, second try

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Marc-Antoine Ruel
<maruel at chromium.org>'s request for review:
Bug 32075: Add workaround for json parsed as unicode
https://bugs.webkit.org/show_bug.cgi?id=32075

Attachment 44172: master.cfg patch, second try
https://bugs.webkit.org/attachment.cgi?id=44172&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.  I think in general this looks fine.

Typo:
 323	 Some simplejson version will always return unicode strings. Python

"versions"

Do we know which versions?  It would be best if the comment documented which
versions were bad so that we would have some idea when we could rip out this
hack.  We could even make the hack a noop for newer versions, although that
seems unecesary optimization.

I'm not sure that your isinstance checks are the slickest way to do this via
python, but I don't know how else you'd differentiate between a dict and a
sequence.

In the end Mark Rowe will have to push this new version to the master server,
so he'll see this code go by anyway.

I'm happy to r+ a version with the fixed comment (ideally one which includes
version information).  Feel free to ping me via email if I don't see your
review go by right away.