[webkit-reviews] review granted: [Bug 31802] Switch Chrome on Mac to Core Text APIs : [Attachment 44532] Add optional ATSUI/Core Text runtime switch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 31802: Switch Chrome on Mac to Core Text APIs
https://bugs.webkit.org/show_bug.cgi?id=31802

Attachment 44532: Add optional ATSUI/Core Text runtime switch
https://bugs.webkit.org/attachment.cgi?id=44532&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I dont' think the ALWAYS_INLINE actually does anything here:
 90	    ALWAYS_INLINE CFIndex indexAt(size_t i) const;

One of these days we should change these to take an ENUM which is RTL vs. LTR,
as that would make all the callsites easier to read:
 101	     void createTextRunFromFontDataATSUI(bool ltr);
(Yes, totally out of scope for this patch.)

In general this looks fine.  It would be nice to see mitz's stamp of approval
on this, but I feel pretty confident this is correct.

Lets give mitz a few days to comment in case he's just been swamped.