[webkit-reviews] review denied: [Bug 31173] Implement WebGLUniformLocation and change API to use it : [Attachment 44452] A patch adding the class WebGLUniformLocation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 8 11:18:01 PST 2009


Eric Seidel <eric at webkit.org> has denied Peterson Trethewey
<petersont at google.com>'s request for review:
Bug 31173: Implement WebGLUniformLocation and change API to use it
https://bugs.webkit.org/show_bug.cgi?id=31173

Attachment 44452: A patch adding the class WebGLUniformLocation
https://bugs.webkit.org/attachment.cgi?id=44452&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The tabs will make this patch impossible to land as-is.  I suggest running
check-webkit-style locally and re-posting.

XCode has a setting for using spaces instead of tabs in the preferences under
"Text Editing".


More information about the webkit-reviews mailing list