[webkit-reviews] review denied: [Bug 30000] [GStreamer] Check return values of gst_element_set_state() : [Attachment 44398] Check return values of gst_element_set_state()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 8 11:26:28 PST 2009


Eric Seidel <eric at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 30000: [GStreamer] Check return values of gst_element_set_state()
https://bugs.webkit.org/show_bug.cgi?id=30000

Attachment 44398: Check return values of gst_element_set_state()
https://bugs.webkit.org/attachment.cgi?id=44398&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It seems play and pause could share all of their code here in a single method
which took either GST_STATE_PAUSED or GST_STATE_PLAYING.

I think that would be cleaner long-term.


More information about the webkit-reviews mailing list