[webkit-reviews] review granted: [Bug 32178] Need to test that WebSocket protocol argument works : [Attachment 44381] Add tests that WebSocket protocol argument works.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 32178: Need to test that WebSocket protocol argument works
https://bugs.webkit.org/show_bug.cgi?id=32178

Attachment 44381: Add tests that WebSocket protocol argument works.
https://bugs.webkit.org/attachment.cgi?id=44381&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +// Failes if protocol is an empty string.

Spelling error here, "Fails" or "Failures" would be right, but "Failes" is
wrong.

> +// Failes if protocol contains an character less than U+0021.
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "sub protocol")');
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u0009")');
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u000A")');
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u000D")');
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u001B")');

Seems this should have a test for the character "\u0000".

> +// Fails if protocol containns an character greater than U+007F.
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u0080")');
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u3042")');

I’d like to see some special characters covered here like \uFFFF, \uFEFF,
\uFFFE, and surrogate pairs.