[webkit-reviews] review granted: [Bug 29005] The values of RuntimeArray are not enumerable : [Attachment 44394] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 7 09:42:32 PST 2009
Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 29005: The values of RuntimeArray are not enumerable
https://bugs.webkit.org/show_bug.cgi?id=29005
Attachment 44394: Patch
https://bugs.webkit.org/attachment.cgi?id=44394&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + const unsigned int length = getLength();
On the next line of code you use "unsigned" but here you used "unsigned int".
Further, you mark this local variable "const" and we don't do that in WebKit.
There are so many that could be marked const, and I don't think we want to
start heading that direction now.
r=me despite this slight strangeness
More information about the webkit-reviews
mailing list