[webkit-reviews] review denied: [Bug 31856] Make WebKit build on Windows with ACCELERATED_COMPOSITING turned on. : [Attachment 44280] Replacement patch with all issues addressed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 4 07:19:54 PST 2009


Adam Roben (aroben) <aroben at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 31856: Make WebKit build on Windows with ACCELERATED_COMPOSITING turned on.
https://bugs.webkit.org/show_bug.cgi?id=31856

Attachment 44280: Replacement patch with all issues addressed.
https://bugs.webkit.org/attachment.cgi?id=44280&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Yay, so much smaller!

But you never call WKCACFLayerRenderer::create()!

I also think we need to make sure the D3D/QuartzCore DLLs are delay-loaded so
that WebKit can launch/run without them present. We can probably do this right
in the vcproj (I don't think it's harmful to specify /delayload for a DLL that
you don't end up linking against (in non-ACCELERATED_COMPOSITING builds)), or
we could do it via more #pragma comment lines.

So close!


More information about the webkit-reviews mailing list