[webkit-reviews] review denied: [Bug 24001] [GTK] Cache control APIs : [Attachment 44307] Patch upgraded and reviewed

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 24001: [GTK] Cache control APIs
https://bugs.webkit.org/show_bug.cgi?id=24001

Attachment 44307: Patch upgraded and reviewed
https://bugs.webkit.org/attachment.cgi?id=44307&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> @@ -2543,6 +2546,8 @@ static void
webkit_web_view_settings_notify(WebKitWebSettings* webSettings, GPar
>	   if (page)
>	      
page->setTabKeyCyclesThroughElements(g_value_get_boolean(&value));
>      }
> +    else if (name == g_intern_string("enable-page-cache"))
> +	   settings->setUsesPageCache(g_value_get_boolean(&value));
>      else if (!g_object_class_find_property(G_OBJECT_GET_CLASS(webSettings),
name))
>	   g_warning("Unexpected setting '%s'", name);
>      g_value_unset(&value);

Like the bot already told us, this else if should be on the line with the }.
The variable name is fine, though, leave it as is. Aside from this, the patch
looks good, so I would say just fix this and reupload so we can set cq+.