[webkit-reviews] review requested: [Bug 27706] WebCore NPAPI implementations should share more code : [Attachment 38813] Join the various PluginView destructors into one shared implementation

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has asked  for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 38813: Join the various PluginView destructors into one shared
implementation
https://bugs.webkit.org/attachment.cgi?id=38813&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
https://bugs.webkit.org/show_bug.cgi?id=27706

Differences to the original implementation are as follows:

- The Mac port does not set m_window to 0 anymore

- The Qt port used to delete the platform plugin widget as
the last step. Now this is done before cleaning up the
script objects and unloading the plugin package (like
the Win port).

* plugins/PluginView.cpp:
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
---
 7 files changed, 79 insertions(+), 101 deletions(-)