[webkit-reviews] review requested: [Bug 27706] WebCore NPAPI implementations should share more code : [Attachment 38812] Share PluginView::init() between ports

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has asked  for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 38812: Share PluginView::init() between ports
https://bugs.webkit.org/attachment.cgi?id=38812&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
Patch by Tor Arne Vestbø <tor.arne.vestbo at nokia.com> on 2009-08-31
Reviewed by NOBODY (OOPS!).

The port-spesific bits are moved to platformStart(), which now returns
a bool based on the success of the platformStart.

https://bugs.webkit.org/show_bug.cgi?id=27706

PluginViewMac used to call stop() in some cases, but this error handling
should be unified across the different implementations, so removing for now.

m_hasPendingGeometryChange is now initialized in the initializer list
instead of in PluginViewQt's init()

* plugins/PluginView.cpp:
* plugins/PluginView.h:
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
---
 8 files changed, 83 insertions(+), 119 deletions(-)