[webkit-reviews] review granted: [Bug 28830] [Gtk] DRT needs implementation of overridePreference : [Attachment 38780] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 31 03:13:56 PDT 2009

Eric Seidel <eric at webkit.org> has granted Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 28830: [Gtk] DRT needs implementation of overridePreference

Attachment 38780: Patch v1

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks great!

I would have named "toWebSettingKey" "copyAsWebSettingKey" or something.  To
inform the caller that they need to release the returned string.

It's so sad that we don't have some sort of GOwnPtr for DRT to use here instead
of needing to manually g_free.

+	     if ( !(ss >> val).fail())

+    static gboolean isInitialized = false;
is not really needed, you can check !keyTable.

Please adjust a little before landing.

More information about the webkit-reviews mailing list