[webkit-reviews] review denied: [Bug 28831] Make ElementTimeControl methods return void and not throw : [Attachment 38781] Patch v1

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Cameron McCormack <cam at mcc.id.au>'s
request for review:
Bug 28831: Make ElementTimeControl methods return void and not throw
https://bugs.webkit.org/show_bug.cgi?id=28831

Attachment 38781: Patch v1
https://bugs.webkit.org/attachment.cgi?id=38781&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks great!  I assume the spec must have changed from when we wrote these?

Looks good except for lack of testing.	r- for lack of tests.  Just something
simple to make sure these return undefined would be sufficient.

DOM-only tests would be best for these:
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree

shouldBeUndefined("svg.beginElement()");
shouldBeUndefined("svg.beginElementAt(NaN)");
shouldBeUndefined("svg.endElement()");
shouldBeUndefined("svg.endElementAt(NaN)");
etc.

Thanks for the patch!