[webkit-reviews] review granted: [Bug 28681] Element::recalcStyle() accesses freed RenderStyles (fast/css/rem-dynamic-scaling.html) : [Attachment 38498] patch2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 24 14:09:03 PDT 2009
Eric Seidel <eric at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 28681: Element::recalcStyle() accesses freed RenderStyles
(fast/css/rem-dynamic-scaling.html)
https://bugs.webkit.org/show_bug.cgi?id=28681
Attachment 38498: patch2
https://bugs.webkit.org/attachment.cgi?id=38498&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
We should probably add a comment as to why it's held in a RefPtr. I believe
you're a committer now, so you could add that when landing.
Something like:
// Ref the currentStyle in case it's deleted when we call setStyle().
More information about the webkit-reviews
mailing list