[webkit-reviews] review requested: [Bug 28682] [Qt] QtWebKit Persistent API : [Attachment 38500] first try.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 24 14:28:22 PDT 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 28682: [Qt] QtWebKit Persistent API
https://bugs.webkit.org/show_bug.cgi?id=28682

Attachment 38500: first try.
https://bugs.webkit.org/attachment.cgi?id=38500&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Putting this up for review to collect feedback. Patch implements the
followings:

- Disable LocalStorage, ApplicationCache, HTML5 offline storage by default
- If persistency is enabled the default directory for LocalStorage and
ApplicationCache is now based on QDesktopServices::DataLocation and not
QDesktopServices::CacheLocation
- If persistency is enabled initialize HTML5 offline storage as well - this
fixed offline Storage for QtLauncher (it is crashing now)

Looking for feedback on
 - function name and signature for enablePersistentStorage
 - Is there a need/can we maintain a disablePersistentStorage function (other
WebKit ports does not seems to have this option)


More information about the webkit-reviews mailing list