[webkit-reviews] review granted: [Bug 28345] [GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly : [Attachment 35016] Patch with variable names according to conventions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 23 00:11:44 PDT 2009


Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<martin.james.robinson at gmail.com>'s request for review:
Bug 28345: [GTK] BitmapImage::getGdkPixbuf does not handle alpha channels
properly
https://bugs.webkit.org/show_bug.cgi?id=28345

Attachment 35016: Patch with variable names according to conventions
https://bugs.webkit.org/attachment.cgi?id=35016&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
This looks good to me, and on top of fixing a bug it manages to do the data
conversion on the client side. There's a NULL where we should use 0, but I'll
fix that when landing.


More information about the webkit-reviews mailing list