[webkit-reviews] review requested: [Bug 28665] Inspector: Throws an Error on "null" : [Attachment 38447] [PATCH] One Possible Solution

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 23 00:04:03 PDT 2009

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 28665: Inspector: Throws an Error on "null"

Attachment 38447: [PATCH] One Possible Solution

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
No other falsey value causes wrapObject() to return a null value (NaN,
undefined, 0, '').  This solution tackles null before calling wrapObject. 
Another solution could be checking the result of wrapObject (wrapper).	And yet
another solution could handle null differently inside
InspectorController.wrapObject().  This approach seemed simplest.

Pavel, would there be a more appropriate solution?

More information about the webkit-reviews mailing list