[webkit-reviews] review requested: [Bug 27944] Geolocation error callback not called if permissions have already been denied : [Attachment 38375] Patch 2 for bug 27944
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 21 09:21:06 PDT 2009
steveblock at google.com has asked for review:
Bug 27944: Geolocation error callback not called if permissions have already
been denied
https://bugs.webkit.org/show_bug.cgi?id=27944
Attachment 38375: Patch 2 for bug 27944
https://bugs.webkit.org/attachment.cgi?id=38375&action=review
------- Additional Comments from steveblock at google.com
> We don't have a find method for this type?
I'm not aware of one that searches the value, rather than the key, of the map.
> Style:
Fixed
> No need to store it locally first:
Fixed
> Aren't the two if (isDenied()) blocks your editing identical? Cant' we share
> code there?
Fixed
> Arguments are only named when the name adds clarity:
Fixed
> Who would know about this code? I certainly don't.
It was written by Greg Bolsinga, but he's not a WebKit reviewer.
More information about the webkit-reviews
mailing list