[webkit-reviews] review canceled: [Bug 27944] Geolocation error callback not called if permissions have already been denied : [Attachment 34779] Patch 1 for bug 27944

[bugzilla-daemon at webkit.org]

steveblock at google.com has canceled steveblock at google.com's request for review:
Bug 27944: Geolocation error callback not called if permissions have already
been denied
https://bugs.webkit.org/show_bug.cgi?id=27944

Attachment 34779: Patch 1 for bug 27944
https://bugs.webkit.org/attachment.cgi?id=34779&action=review

------- Additional Comments from steveblock at google.com
> We don't have a find method for this type?
I'm not aware of one that searches the value, rather than the key, of the map.

> Style:
Fixed

> No need to store it locally first:
Fixed

> Aren't the two if (isDenied()) blocks your editing identical?  Cant' we share

> code there?
Fixed

> Arguments are only named when the name adds clarity:
Fixed

> Who would know about this code?  I certainly don't.
It was written by Greg Bolsinga, but he's not a WebKit reviewer.