[webkit-reviews] review granted: [Bug 28054] use derefInNotNull function to work around winscw compiler bug regarding template arguments. : [Attachment 35216] modifed patch according to Darin's and Eric's comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 20 12:55:47 PDT 2009


Eric Seidel <eric at webkit.org> has granted Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 28054: use derefInNotNull function to work around winscw compiler bug
regarding template arguments.
https://bugs.webkit.org/show_bug.cgi?id=28054

Attachment 35216: modifed patch according to Darin's and Eric's comments.
https://bugs.webkit.org/attachment.cgi?id=35216&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This will likely slow down debug builds, since I don't think debug builds
inline anything.  That's OK.

This looks fine.


More information about the webkit-reviews mailing list