[webkit-reviews] review granted: [Bug 28497] REGRESSION: Images don't repaint properly if their size changes on a line : [Attachment 35218] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 20 12:44:59 PDT 2009
mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 28497: REGRESSION: Images don't repaint properly if their size changes on a
line
https://bugs.webkit.org/show_bug.cgi?id=28497
Attachment 35218: Patch
https://bugs.webkit.org/attachment.cgi?id=35218&action=review
------- Additional Comments from mitz at webkit.org
> + int boxHeight = curr->height();
> + int childTopOverflow = box->hasOverflowClip() ? 0 :
box->topLayoutOverflow();
Not sure a local variable is needed here (but really I’m more bothered by the
inconsistency with the horizontal case where you didn’t use a local var :-) ).
r=me!
More information about the webkit-reviews
mailing list