[webkit-reviews] review granted: [Bug 28449] [v8] Use atomic string caching for createElement : [Attachment 35106] Unrelated changes removed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 19 21:28:49 PDT 2009
David Levin <levin at chromium.org> has granted review:
Bug 28449: [v8] Use atomic string caching for createElement
https://bugs.webkit.org/show_bug.cgi?id=28449
Attachment 35106: Unrelated changes removed
https://bugs.webkit.org/attachment.cgi?id=35106&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> +++ WebCore/bindings/scripts/IDLParser.pm (working copy)
> + my @params = split(/,(?![^[]*])/, $methodSignature);
Although apparently valid without this, it would be nice to escape the last ]
to clue in the reader that it isn't a closing ] in the regex.
More information about the webkit-reviews
mailing list