[webkit-reviews] review granted: [Bug 24853] Provide a way for WebKit clients to specify a more granular policy for cross-origin XHR access : [Attachment 35181] New patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Aaron Boodman <aa at chromium.org>'s
request for review:
Bug 24853: Provide a way for WebKit clients to specify a more granular policy
for cross-origin XHR access
https://bugs.webkit.org/show_bug.cgi?id=24853

Attachment 35181: New patch
https://bugs.webkit.org/attachment.cgi?id=35181&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Only one minor nit which would be nice for someone to fix on landing.... (I'm
willing to do so).

> diff --git a/WebKit/gtk/webkit/webkitprivate.cpp
b/WebKit/gtk/webkit/webkitprivate.cpp
>  #include "ResourceHandleClient.h"
>  #include "ResourceHandleInternal.h"
>  #include <runtime/InitializeThreading.h>
> +#include "SecurityOrigin.h"

The <> headers come after the "" headers.

 

> > Omit param name: sourceOrigin
> I feel like it clarifies...
You are right.	I read it too quickly as securityOrigin.

> I think they are all there, though the formatting was weird. Fixed
Thanks.  I must have read it too quickly again.