[webkit-reviews] review denied: [Bug 28449] [v8] Use atomic string caching for createElement : [Attachment 35106] Unrelated changes removed

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Christian Plesner Hansen
<christian.plesner.hansen at gmail.com>'s request for review:
Bug 28449: [v8] Use atomic string caching for createElement
https://bugs.webkit.org/show_bug.cgi?id=28449

Attachment 35106: Unrelated changes removed
https://bugs.webkit.org/attachment.cgi?id=35106&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> Index: WebCore/bindings/scripts/CodeGeneratorV8.pm

Why did this attribute change?


> Index: WebCore/bindings/scripts/IDLParser.pm
> +		   # Split arguments at commas but only if the comma
> +		   # is not within attribute brackets, expressed here
> +		   # as being followed by a ']' without a preceding '['.
> +		   # Note that this assumes that attributes don't nest.
> +		   my @params = split(/,(?![^[]*])/, $methodSignature);

I don't understand how this regex does what the comment says.

It looks like it splits on commas that are followed by anything except these
three characters: '[', ']', '*'
(using a negative width lookahead assertion).