[webkit-reviews] review requested: [Bug 28473] Crashes on sites with lots of images : [Attachment 35148] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 15:00:53 PDT 2009


David Levin <levin at chromium.org> has asked  for review:
Bug 28473: Crashes on sites with lots of images
https://bugs.webkit.org/show_bug.cgi?id=28473

Attachment 35148: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=35148&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Free free to r- for lack of tests :) but I wanted to get feedback about the
patch without that part.

For the layout tests, here's what I'm thinking about (approximately and it will
take a bit of tweaking for me to hit these conditions precisely):
  Add a new cache model (or see if I can do it with existing models) and allow
it to be selected from LayoutTestController.
  Load a bunch of images to hit the boundary and expose this issue.

Feel free to give feedback on that approach as well.


More information about the webkit-reviews mailing list