[webkit-reviews] review denied: [Bug 28423] Two layout tests are convertible to dumpAsText : [Attachment 35035] Convert two layout tests so that they use dumpAsText().
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 18 15:01:44 PDT 2009
Eric Seidel <eric at webkit.org> has denied Yuta Kitamura <yutak at chromium.org>'s
request for review:
Bug 28423: Two layout tests are convertible to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=28423
Attachment 35035: Convert two layout tests so that they use dumpAsText().
https://bugs.webkit.org/attachment.cgi?id=35035&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I would rather have "technically invalid" html, than tests full of a bunch of
boiler-plate.
This test succeeds if it does not crash.
<table<td style="-webkit-columns: -9999px;">
<script>
if (window.layoutTestController)
layoutTestController.dumpAsText()
</script>
would have been sufficient.
WebKit style is 4 space indent. so r-.
More information about the webkit-reviews
mailing list