[webkit-reviews] review granted: [Bug 28342] SharedWorkers need to support loading : [Attachment 34904] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 15:01:13 PDT 2009


David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at chromium.org>'s request for review:
Bug 28342: SharedWorkers need to support loading
https://bugs.webkit.org/show_bug.cgi?id=28342

Attachment 34904: proposed patch
https://bugs.webkit.org/attachment.cgi?id=34904&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/LayoutTests/http/tests/workers/resources/worker-importScripts.js
b/LayoutTests/http/tests/workers/resources/worker-importScripts.js
> +if (self.postMessage)
> +    runTests();
> + else
> +	onconnect = handleConnect;

Indented too far.


> diff --git
a/LayoutTests/http/tests/xmlhttprequest/workers/resources/close-test.js
b/LayoutTests/http/tests/xmlhttprequest/workers/resources/close-test.js
> +   function done()

I realize this is just a copy but it would be nice to fix the indent here.


More information about the webkit-reviews mailing list