[webkit-reviews] review requested: [Bug 28370] check-webkit-style: add check for 'using std::foo; ' statements : [Attachment 34940] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 16 15:35:55 PDT 2009

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 28370: check-webkit-style: add check for 'using std::foo;' statements

Attachment 34940: Patch v1

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

In <http://webkit.org/b/28355#c1>, it was noted that new source
files use 'using namespace std;' instead of individual
'use std::foo;' statements.  This adds a level 4 check for such

* Scripts/modules/cpp_style.py:
(_ERROR_CATEGORIES): Added 'build/using_std'.
(check_using_std): Added.
(check_style): Added call to check_using_std().
* Scripts/modules/cpp_style_unittest.py:
(WebKitStyleTest.test_using_std): Added unit test.
 3 files changed, 54 insertions(+), 0 deletions(-)

More information about the webkit-reviews mailing list