[webkit-reviews] review requested: [Bug 28367] bugzilla.py: replace ScriptError class with BugzillaError class : [Attachment 34938] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 16 15:16:03 PDT 2009
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked for review:
Bug 28367: bugzilla.py: replace ScriptError class with BugzillaError class
https://bugs.webkit.org/show_bug.cgi?id=28367
Attachment 34938: Patch v1
https://bugs.webkit.org/attachment.cgi?id=34938&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).
The ScriptError class doesn't exist in bugzilla.py, so any
errors print error messages about ScriptError instead of the
actual error:
NameError: global name 'ScriptError' is not defined
* Scripts/modules/bugzilla.py:
(BugzillaError): Added class. Modeled after ScriptError class
in scm.py.
(Bugzilla.authenticate): Changed to use BugzillaError instead of
ScriptError.
(Bugzilla._check_create_bug_response): Ditto.
---
2 files changed, 26 insertions(+), 2 deletions(-)
More information about the webkit-reviews
mailing list