[webkit-reviews] review requested: [Bug 28352] Fix coding style issues in yarr/RegexInterpreter.cpp : [Attachment 34924] 2009-08-16 Holger Hans Peter Freyther <zecke at selfish.org>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 16 02:27:40 PDT 2009


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 28352: Fix coding style issues in yarr/RegexInterpreter.cpp
https://bugs.webkit.org/show_bug.cgi?id=28352

Attachment 34924: 2009-08-16  Holger Hans Peter Freyther  <zecke at selfish.org>
https://bugs.webkit.org/attachment.cgi?id=34924&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Reviewed by NOBODY (OOPS!).

https://bugs.webkit.org/show_bug.cgi?id=28352

Fix coding style violations. Use m_ for C++ class members. Remove
trailing whitespace on empty lines.

* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionC
ontext):
(JSC::Yarr::Interpreter::tryConsumeCharacter):
(JSC::Yarr::Interpreter::tryConsumeBackReference):
(JSC::Yarr::Interpreter::parenthesesDoBacktrack):
(JSC::Yarr::Interpreter::backtrackParentheses):
(JSC::Yarr::ByteCompiler::ByteCompiler):
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::checkInput):
(JSC::Yarr::ByteCompiler::assertionBOL):
(JSC::Yarr::ByteCompiler::assertionEOL):
(JSC::Yarr::ByteCompiler::assertionWordBoundary):
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
(JSC::Yarr::ByteCompiler::popParenthesesStack):
(JSC::Yarr::ByteCompiler::closeAlternative):
(JSC::Yarr::ByteCompiler::closeBodyAlternative):
(JSC::Yarr::ByteCompiler::atomParenthesesEnd):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction):
(JSC::Yarr::ByteCompiler::alterantiveDisjunction):
(JSC::Yarr::ByteCompiler::emitDisjunction):
---
 2 files changed, 145 insertions(+), 110 deletions(-)


More information about the webkit-reviews mailing list