[webkit-reviews] review requested: [Bug 28353] yarr/RegexInterpreter.cpp crashes on ./ecma_2/RegExp/exec-002.js : [Attachment 34923] 2009-08-16 Holger Hans Peter Freyther <zecke at selfish.org>

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 28353: yarr/RegexInterpreter.cpp crashes on ./ecma_2/RegExp/exec-002.js
https://bugs.webkit.org/show_bug.cgi?id=28353

Attachment 34923: 2009-08-16  Holger Hans Peter Freyther  <zecke at selfish.org>
https://bugs.webkit.org/attachment.cgi?id=34923&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Reviewed by NOBODY (OOPS!).

Fix crash on ./ecma_2/RegExp/exec-002.js.
https://bugs.webkit.org/show_bug.cgi?id=28353

Change the order of freeParenthesesDisjunctionContext and
popParenthesesDisjunctionContext on all call sites as the pop
method is accessing backTrack->lastContext which is the context
that is about to be freed.

* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::parenthesesDoBacktrack):
(JSC::Yarr::Interpreter::backtrackParentheses):
---
 2 files changed, 19 insertions(+), 3 deletions(-)