[webkit-reviews] review granted: [Bug 28324] Add a test to verify that page cache can be enabled for a test : [Attachment 34877] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 14 17:13:56 PDT 2009

Eric Seidel <eric at webkit.org> has granted Dmitry Titov <dimich at chromium.org>'s
request for review:
Bug 28324: Add a test to verify that page cache can be enabled for a test

Attachment 34877: Proposed patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
Yay for trailblazing!

The test makes sense to me.  I assume you've tested to make sure it fails with:

layoutTestController.overridePreference("WebKitUsesPageCachePreferenceKey", 1);

commented out.

I'm not sure we have a test to verify that onload would be sent twice w/ the
page cache off.  That seems useful to test.

Eventually we'll want to make this sort of thing into a framework, so that it's
easy to test page-cache bugs.  For example, we want to test what sort of things
prevents a page from entering the cache.  Ideally that will eventually be as
easy as making a single function call in a test with a little HTML passed to
it. :)	But I dream...

LGTM assuming you've tested with the page cache off to make sure it fails.

More information about the webkit-reviews mailing list