[webkit-reviews] review denied: [Bug 28329] HTML5 canvas's createImageData should raise the NOT_SUPPORTED_ERR exception when either of the arguments are not finite. : [Attachment 34878] Patch to solve the issue

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Benjamin Meyer <ben at meyerhome.net>'s
request for review:
Bug 28329: HTML5 canvas's createImageData should raise the NOT_SUPPORTED_ERR
exception when either of the arguments are not finite.
https://bugs.webkit.org/show_bug.cgi?id=28329

Attachment 34878: Patch to solve the issue
https://bugs.webkit.org/attachment.cgi?id=34878&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Fix looks great.

But we also require a regression test for fixes like this one. Please resubmit
a patch that includes a regression test.

It should be straightforward to come up for a test for this. We don't need to
use the canvas tests you referred to in the bug earlier. If you look in the
LayoutTests/fast/canvas directory you'll see many other similar tests which
could give you some ideas how to make a test that covers this fix.