[webkit-reviews] review granted: [Bug 28258] [Haiku] Adding RenderTheme to WebCore. : [Attachment 34738] Adding RenderTheme to WebCore.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 09:57:11 PDT 2009

Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28258: [Haiku] Adding RenderTheme to WebCore.

Attachment 34738: Adding RenderTheme to WebCore.

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks OK.

This will error out if -wunused is on:
 41	    virtual bool supportsHover(const RenderStyle* style) const { return
false; }

not enough to warrant a re-review, but I expect you'll turn on -wunused like
the rest of ports someday, so you'll want to fix that eventually.

More information about the webkit-reviews mailing list