[webkit-reviews] review denied: [Bug 12052] Assertion failure in WebCore::RenderHTMLCanvas::layout : [Attachment 34730] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 12052: Assertion failure in WebCore::RenderHTMLCanvas::layout
https://bugs.webkit.org/show_bug.cgi?id=12052

Attachment 34730: Patch v1
https://bugs.webkit.org/attachment.cgi?id=34730&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
review- because of the double change log in the LayoutTests directory.

> +    // block.  We also don't handle the run-in if the element isn't a
> +    // block (e.g., <canvas>, <video>, and etc.).
> +    if (!child->isRunIn() || !child->childrenInline() &&
!child->isReplaced() || !child->isRenderBlock())
>	   return false;

This definitely gets rid of the assertion/crash, but I am not 100% certain it's
correct. I'd like to hear from Hyatt or Dan Bernstein.