[webkit-reviews] review denied: [Bug 27543] Add platform/wince/ files for WINCE port : [Attachment 34374] 1) Clipboard

Wed Aug 12 12:17:21 PDT 2009

George Staikos <staikos at kde.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 34374: 1) Clipboard
https://bugs.webkit.org/attachment.cgi?id=34374&action=review

------- Additional Comments from George Staikos <staikos at kde.org>

> +static bool getWebLocData(IDataObject* dataObject, String& url, String*
title)
> +{
> +    return false;
> +}

Should probably add some UNUSED_PARAM() here

> +    CString cf_html = "Version:0.9";
> +    CString startHTML = "\nStartHTML:";
> +    CString endHTML = "\nEndHTML:";
> +    CString startFragment = "\nStartFragment:";
> +    CString endFragment = "\nEndFragment:";
> +    CString sourceURL = "\nSourceURL:";
> +
> +    append(result, cf_html);
> +
> +    bool shouldFillSourceURL = !srcURL.isEmpty() && (srcURL !=
"about:blank");
> +
> +    CString startMarkup = "\n<HTML>\n<BODY>\n<!--StartFragment-->\n";
> +    CString endMarkup = "\n<!--EndFragment-->\n</BODY>\n</HTML>";

   all these CString should be "const" right?  static too maybe?

> +void ClipboardWince::clearData(const String& type)
> +{
> +    notImplemented();
> +}

This file can use lots of UNUSED_PARAM()

The rest seems fine