[webkit-reviews] review denied: [Bug 27543] Add platform/wince/ files for WINCE port : [Attachment 34379] 5) ContextMenu

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 12 12:12:19 PDT 2009


George Staikos <staikos at kde.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 34379: 5) ContextMenu
https://bugs.webkit.org/attachment.cgi?id=34379&action=review

------- Additional Comments from George Staikos <staikos at kde.org>

> +    m_platformDescription = new PlatformMenuItemDescriptionType;
> +    if (!m_platformDescription)
> +	   return;

   Don't think we should be checking for null here.

> +void ContextMenuItem::setSubMenu(ContextMenu* subMenu)
> +{
> +    if (!m_platformDescription)
> +	   return;

  In fact can we remove all of these checks?


More information about the webkit-reviews mailing list