[webkit-reviews] review requested: [Bug 23642] [GTK] Drag and drop support : [Attachment 34659] Third patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 12 06:15:31 PDT 2009


Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 23642: [GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Attachment 34659: Third patch
https://bugs.webkit.org/attachment.cgi?id=34659&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
This patch now does not use DragClipboard, but requests contents of different
clipboards. Which clipboard is requested depends on the type of drag data we
need to provide.
WebKit::DragClient::startDrag now uses more of the obejcts passed to it when
called - previously, we searched for focused frame and checked whether target
element is a link to set drag action flags properly, now we use frame passed in
by WebCore::DragController and look up to boolean value of linkDrag.

Also attached is a manual test that gives directions to test different drag
situations.

Anything else left unresponded from the comments #34-#36 will be responded to
in a minute.


More information about the webkit-reviews mailing list