[webkit-reviews] review granted: [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP : [Attachment 34648] resubmit the patch to address comments

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 23727: Implementaion of WCSS marquee extension relevant to XHML MP
https://bugs.webkit.org/show_bug.cgi?id=23727

Attachment 34648: resubmit the patch to address comments
https://bugs.webkit.org/attachment.cgi?id=34648&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hi Charles,

patch looks great, along with your comments (regarding the impossiblity to
not-hardcode the stuff.)

One last question:

> Index: WebCore/css/WCSSValueKeywords.in
> ===================================================================
> --- WebCore/css/WCSSValueKeywords.in	(revision 0)
> +++ WebCore/css/WCSSValueKeywords.in	(revision 0)
> @@ -0,0 +1 @@
> +# place holder for all WCSS specific CSS value keywords

Do we need this file? I suspect you _may_ need it for the build process?
If not, please remove this file completly, and reupload a patch, then I'll set
"commit-queue +" as well.