[webkit-reviews] review denied: [Bug 27965] ImageSourceFoo.cpp contains lots of Copy+Paste code and should be refactored : [Attachment 34632] Merge in ImageSourceWx.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 19:01:55 PDT 2009


Adam Treat <treat at kde.org> has denied Peter Kasting <pkasting at google.com>'s
request for review:
Bug 27965: ImageSourceFoo.cpp contains lots of Copy+Paste code and should be
refactored
https://bugs.webkit.org/show_bug.cgi?id=27965

Attachment 34632: Merge in ImageSourceWx.cpp 
https://bugs.webkit.org/attachment.cgi?id=34632&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
I think the approach is sound, but indentation problems prevent r+.  Looks like
ImageSourceFoo* is close to complete unforking though :)


More information about the webkit-reviews mailing list