[webkit-reviews] review requested: [Bug 27965] ImageSourceFoo.cpp contains lots of Copy+Paste code and should be refactored : [Attachment 34632] Merge in ImageSourceWx.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 18:55:33 PDT 2009


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 27965: ImageSourceFoo.cpp contains lots of Copy+Paste code and should be
refactored
https://bugs.webkit.org/show_bug.cgi?id=27965

Attachment 34632: Merge in ImageSourceWx.cpp 
https://bugs.webkit.org/attachment.cgi?id=34632&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
After reviewing the functions in ImageSourceWx.cpp, I believe everything in
ImageSource.cpp is suitable, and no changes are needed; so I'm simply deleting
ImageSourceWx.cpp and updating the Bakefiles.

I remember that Wx was going to move away from Bakefiles, but there are no
other checked-in files which reference ImageSourceWx.cpp besides the ones I've
modified, so I assume either that hasn't happened yet or it's still private.


More information about the webkit-reviews mailing list