[webkit-reviews] review denied: [Bug 28161] Qt DumpRenderTree does not process named events. : [Attachment 34500] Code change for DumpRenderTree keyDown processing.

[bugzilla-daemon at webkit.org]

Adam Treat <treat at kde.org> has denied Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 28161: Qt DumpRenderTree does not process named events.
https://bugs.webkit.org/show_bug.cgi?id=28161

Attachment 34500: Code change for DumpRenderTree keyDown processing.
https://bugs.webkit.org/attachment.cgi?id=34500&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
This is awesome!  I imagine this will fix quite a few tests :)

A few comments:

> +    } else {
> +	   qDebug() << ">>>>>>>>> keyDown" << string;

Is this necessary?

> +	   // map special keycode strings used by the tests to something that
works for Qt/X11
> +	   if (string == "leftArrow") {

string == QLatin1String("leftArrow") I think.  r- to change.  And then I'll
land :)