[webkit-reviews] review denied: [Bug 28128] [Haiku] Modifications on WebCore. : [Attachment 34554] Patch to modify some WebCore/platform/ files to allow the Haiku port.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 07:55:52 PDT 2009


Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28128: [Haiku] Modifications on WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28128

Attachment 34554: Patch to modify some WebCore/platform/ files to allow the
Haiku port.
https://bugs.webkit.org/attachment.cgi?id=34554&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
m_ for member variables:
 #if PLATFORM(MAC)
213218	   WidgetPrivate* m_data;
 219 #elif PLATFORM(HAIKU)
 220	 WidgetPrivate* data;
214221 #endif

Otherwise this looks fine.  If you were a committer I would r+ this and you
could fix and land it yourself.


More information about the webkit-reviews mailing list