[webkit-reviews] review requested: [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage : [Attachment 34448] second try

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 05:50:08 PDT 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 28036: [Qt] Public API to configure the storage path for HTML5 localStorage
https://bugs.webkit.org/show_bug.cgi?id=28036

Attachment 34448: second try
https://bugs.webkit.org/attachment.cgi?id=34448&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
- remove the "Database" part from the name (e.g. renamed
setLocalStorageDatabasePath to setLocalStoragePath)
- add reference to webstorage spec

Note that WebAttribute enum is still called LocalStorageDatabaseEnabled; since
the enum has been part of the QtWebKit 4.5 API and changing it would be
compatibility break I believe. This means that with this proposal there will be
some inconsistency between the name of the WebAttribute enum and the rest of
the APIs.


More information about the webkit-reviews mailing list