[webkit-reviews] review requested: [Bug 27885] Add QNX as supported platform : [Attachment 34446] Updated version of the QNX patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 10 04:42:50 PDT 2009
Harald Fernengel <harry at kdevelop.org> has asked for review:
Bug 27885: Add QNX as supported platform
https://bugs.webkit.org/show_bug.cgi?id=27885
Attachment 34446: Updated version of the QNX patch
https://bugs.webkit.org/attachment.cgi?id=34446&action=review
------- Additional Comments from Harald Fernengel <harry at kdevelop.org>
Thanks for your comments.
I've removed the C-style cast and used LOG_ERROR instead of perror().
Also, the QNX specific part of getting the current thread's stack base is now
factored out into currentThreadStackBaseQNX(), making it more readable and
removing some #define magic.
QNX offers standard pthreads, so a special Threading* abstraction is not
necessary. Collector.cpp already contains #defines for all platforms that use
standard pthreads but don't offer pthread_getattr_np() to retrieve the stack
base.
More information about the webkit-reviews
mailing list