[webkit-reviews] review denied: [Bug 27511] Add WinCE specific platform/graphics files to WebCore : [Attachment 33814] 2) SharedBitmap

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 14:35:42 PDT 2009

Eric Seidel <eric at webkit.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore

Attachment 33814: 2) SharedBitmap

------- Additional Comments from Eric Seidel <eric at webkit.org>
r- for lack of ChagneLog.

Please run check-webkit-style.

g_ is not a pattern we use:
 static SharedBitmap::DrawPatternFunc g_drawPattern = 0;
 52 static SharedBitmap::DrawImageFunc g_drawImage = 0;

This can't be the only place in the project we need this?
 54 static inline int stableRound(double d)
please look for other implementations.

What is this class even for?  Please explain in a ChagneLog.

Why crateInstance instead of create?
 77 PassRefPtr<SharedBitmap> SharedBitmap::createInstance(bool is16bit, int w,
int h, bool initPixels)

SharedBitmap::SharedBitmap(const BitmapInfo& bmpInfo, HBITMAP hbmp, void*
 88 : m_bmpInfo(bmpInfo)
 89 , m_locked(false)

Please have george review your patches before posting again.  These are not
nearly ready.

More information about the webkit-reviews mailing list