[webkit-reviews] review denied: [Bug 28060] bugzilla-tool needs a --quiet option : [Attachment 34310] An 80% solution.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 14:31:19 PDT 2009


Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 28060: bugzilla-tool needs a --quiet option
https://bugs.webkit.org/show_bug.cgi?id=28060

Attachment 34310: An 80% solution.
https://bugs.webkit.org/attachment.cgi?id=34310&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not sure this is the best way to ignore output.  Not I've used
.communicate() and ginored the results in other places.

Python has a ternary operator.	You better sit down before you read it though:

child_stdout = open(os.devnull, "w") if quiet else None

Why not just print before every subcommand?
print "build-webkit..."
I don't really like the "..."


More information about the webkit-reviews mailing list