[webkit-reviews] review denied: [Bug 27794] [HTML5][Forms] Part 3 of datalist&list: Introduce new pseudo selector, new appearance, and new control part for the list attribute support : [Attachment 33697] Proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 27794: [HTML5][Forms] Part 3 of datalist&list: Introduce new pseudo
selector, new appearance, and new control part for the list attribute support
https://bugs.webkit.org/show_bug.cgi?id=27794

Attachment 33697: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33697&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
No { }:
 if (part == ListButtonPart) {
 337	     [buttonCell setBezelStyle:NSRoundedDisclosureBezelStyle];
 338	 } el

Tabs:
47	   case ListButtonPart:
 448	{
 449		 LengthSize result = sizeFromFont(font,
LengthSize(zoomedSize.width(), Length()), zoomFactor, buttonSizes());
 450		 result.setWidth(result.height());
 451		 return result;
 452	}

Where are the tests?

Parts of this at least should be guarded by some sort of DATALIST define. 
Otherwise this looks OK.