[webkit-reviews] review denied: [Bug 27787] The type information about the resource loading is not forwarded to the network layer : [Attachment 33682] patch which resource type information to the ResourceRequestBase class

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Zsombor <gzsombor at gmail.com>'s request
for review:
Bug 27787: The type information about the resource loading is not forwarded to
the network layer
https://bugs.webkit.org/show_bug.cgi?id=27787

Attachment 33682: patch which resource type information to the
ResourceRequestBase class
https://bugs.webkit.org/attachment.cgi?id=33682&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
r- for lack of ChangeLog.

Please run check-webkit-style.

I think this should just be an argument to the constructor, but I can see how
that would be harry to add given the current design.

Please don't add a default here:
+    default : 
+	 m_resourceType = GenericRequest;
+	 break;
it defeats the point of using a switch for an enum (which is to catch when
something is added to the enum).

Never used, and not needed:
+	 void setResourceType(RequestType type) { m_resourceType = type; }

Hum... but Platform can never depend on WebCore. So this is a layering
violation.

I suggest that instead you make CachedResource use these constants.  And then
CachedResource can cast its own constancts back to these for setting.